chore: Add Azure OpenAI embedding provider #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drazvan
requested changes
Aug 26, 2024
| """Retrieve the embedding dimension for the specified model.""" | ||
| if self.embedding_model in self.MODEL_DIMENSIONS: | ||
| return self.MODEL_DIMENSIONS[self.embedding_model] | ||
| else: |
There was a problem hiding this comment.
We should fall back to computing the embedding for a test string, and take the size from there. Otherwise, if a new model is published, it will not be usable until a new version of nemoguardrails is published.
There was a problem hiding this comment.
@shubhiroy : let me know if you can address these changes in the next few days, so we can include this in the 0.10.0 release. Thanks!
There was a problem hiding this comment.
Hi @drazvan,
I have done the required changes.
- Modified code to compute embedding using test string
- Added details in configuration-guide.md
- Added test
Sorry for late reply. I was not well from last few weeks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for azure open ai embedding model.