Reintroduce "Move old ImageDecoder to legacy module and make the nvImageCodec based ImageDecoder the default" #5470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vImageCodec based ImageDecoder the default (NVIDIA#5445)"" This reverts commit a1b4fbd. Signed-off-by: Joaquin Anton <[email protected]>
Signed-off-by: Joaquin Anton <[email protected]>
jantonguirao
force-pushed
the
reintroduce_nvimagecodec
branch
from
a887fbb
to
bd18094
Compare
jantonguirao
force-pushed
the
reintroduce_nvimagecodec
branch
from
a710ce5
to
9c6cedb
Compare
Signed-off-by: Joaquin Anton <[email protected]>
jantonguirao
force-pushed
the
reintroduce_nvimagecodec
branch
from
9c6cedb
to
c010602
Compare
|
!build |
|
CI MESSAGE: [15065473]: BUILD FAILED |
|
CI MESSAGE: [15066134]: BUILD STARTED |
|
CI MESSAGE: [15066134]: BUILD PASSED |
Signed-off-by: Joaquin Anton <[email protected]>
|
CI MESSAGE: [15089873]: BUILD STARTED |
|
CI MESSAGE: [15089873]: BUILD PASSED |
jantonguirao
commented
May 20, 2024
| @@ -1,4 +1,4 @@ | |||
| # Copyright (c) 2019-2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
| # Copyright (c) 2019-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
There was a problem hiding this comment.
this is just reverting previous changes
jantonguirao
changed the title
stiepan
reviewed
May 20, 2024
Signed-off-by: Joaquin Anton <[email protected]>
szkarpinski
reviewed
May 21, 2024
| st->out_shape = st->parsed_sample.dali_img_info.shape; | ||
| st->out_shape[2] = NumberOfChannels(format_, st->out_shape[2]); | ||
| if (use_orientation_ && | ||
| ((st->parsed_sample.nvimgcodec_img_info.orientation.rotated / 90) & 1)) { |
There was a problem hiding this comment.
(Nitpick) This & is quite non-obvious here. We just want to know if it's rotated by 90 or 270 degrees, why not just
Suggested change
| ((st->parsed_sample.nvimgcodec_img_info.orientation.rotated / 90) & 1)) { | |
| (st->parsed_sample.nvimgcodec_img_info.orientation.rotated % 180 != 0) { |
szkarpinski
approved these changes
May 21, 2024
stiepan
approved these changes
May 21, 2024
|
CI MESSAGE: [15192159]: BUILD STARTED |
Signed-off-by: Joaquin Anton <[email protected]>
jantonguirao
force-pushed
the
reintroduce_nvimagecodec
branch
from
6f616c2
to
ffa5fb0
Compare
|
CI MESSAGE: [15196770]: BUILD STARTED |
|
CI MESSAGE: [15196770]: BUILD FAILED |
|
CI MESSAGE: [15224234]: BUILD STARTED |
|
CI MESSAGE: [15224234]: BUILD FAILED |
|
CI MESSAGE: [15235949]: BUILD STARTED |
jantonguirao
force-pushed
the
reintroduce_nvimagecodec
branch
from
5978608
to
ffa5fb0
Compare
|
!build |
|
CI MESSAGE: [15236466]: BUILD STARTED |
|
CI MESSAGE: [15236466]: BUILD FAILED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other Replaces default ImageDecoders with the nvImageCodec based implementations.
Description:
legacymoduleAdditional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A