Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parameter error in tutorial #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RenShuhuai-Andy
Copy link

In tutorial, some parameters of class mz.dataloader.Dataset are mistakenly placed in class mz.dataloader.DataLoader.

@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #124 into master will decrease coverage by 1.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   95.01%   93.07%   -1.95%     
==========================================
  Files         104      104              
  Lines        3811     3811              
==========================================
- Hits         3621     3547      -74     
- Misses        190      264      +74
Impacted Files Coverage Δ
matchzoo/datasets/snli/load_data.py 26.47% <0%> (-70.59%) ⬇️
matchzoo/datasets/wiki_qa/load_data.py 27.77% <0%> (-69.45%) ⬇️
matchzoo/datasets/quora_qp/load_data.py 33.33% <0%> (-66.67%) ⬇️
matchzoo/utils/get_file.py 73.14% <0%> (-4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49548ad...b2aa0ee. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant