SWIG_Python_str_AsChar removal in SWIG 4.2.0 #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replacement,
SWIG_PyUnicode_AsUTF8AndSize
, has different memory management requirements.Doesn't
ldns_dname_new_frm_str
make a copy of the input string? Then thearginit
/freearg
constructs aren't needed, and the deallocation of the intermediate Python string could happen locally.