ldns: fix the build in FreeBSD's base system #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a copy of the function prototypes for internal functions where necessary. It effectively works around the following compilation error: error: no previous prototype for function [-Werror,-Wmissing-prototypes] Tested on FreeBSD/amd64 (14.0-CURRENT).
dag-erling
reviewed
May 23, 2023
ldns/internal.h
Outdated
|
|
||
| /* util.c */ | ||
| struct tm * | ||
| ldns_serial_arithmetics_gmtime_r(int32_t time, time_t now, struct tm *result); |
There was a problem hiding this comment.
This is already declared in <ldns/util.h>.
ldns/internal.h
Outdated
|
|
||
| /* dnssec_zone.c */ | ||
| ldns_status | ||
| dnssec_zone_equip_zonemd(ldns_dnssec_zone *zone, |
There was a problem hiding this comment.
You'll want to remove the prototype in dnssec_sign.c.
ldns/internal.h
Outdated
|
|
||
| /* net.c */ | ||
| int | ||
| ldns_tcp_bgsend2(ldns_buffer *qbin, |
There was a problem hiding this comment.
These are already declared in <ldns/net.h>.
ldns/internal.h
Outdated
|
|
||
| /* rr.c */ | ||
| ldns_status | ||
| _ldns_rr_new_frm_fp_l_internal(ldns_rr **newrr, FILE *fp, |
There was a problem hiding this comment.
You'll want to remove the prototypes in zone.c and dnssec_zone.c.
ldns/internal.h
Outdated
|
|
||
| /* edns.c */ | ||
| void | ||
| ldns_edns_set_code(ldns_edns_option *edns, ldns_edns_option_code code); |
There was a problem hiding this comment.
These aren't used outside edns.c and should simply be made static.
ldns/internal.h
Outdated
| ldns_serial_arithmetics_gmtime_r(int32_t time, time_t now, struct tm *result); | ||
| #undef ldns_serial_arithmitics_gmtime_r | ||
| struct tm * | ||
| ldns_serial_arithmitics_gmtime_r(int32_t time, time_t now, struct tm *result); |
There was a problem hiding this comment.
This is intentionally not declared anywhere, if you want to silence the warning you should place a prototype right before the definition.
khorben
force-pushed
the
khorben/freebsd-build-fix
branch
from
c57f822
to
2779d15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an ldns/internal.h C header, containing a copy of the function prototypes for internal functions not exposed in the API.
It effectively works around the following compilation error: error: no previous prototype for function [-Werror,-Wmissing-prototypes]
This header is not installed, and does not affect the API exposed.
Tested on FreeBSD/amd64 (14.0-CURRENT).
Note that this was performed on version 1.8.3, but it seems that it still applies in the same way in the
developbranch.