Remove osc-min dependency #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #115 Remove the `osc-min` dependency and implement `toBuffer` and `fromBuffer` functions directly. * **package.json** - Remove the `osc-min` dependency. * **lib/Client.mjs** - Implement the `toBuffer` function directly in this file. - Replace the import of `osc-min` with the new `toBuffer` function. * **lib/internal/decode.mjs** - Implement the `fromBuffer` function directly in this file. - Replace the import of `osc-min` with the new `fromBuffer` function. * **rollup.config.mjs** - Remove `osc-min` from the external dependencies. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/MylesBorins/node-osc/issues/115?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #115
Remove the
osc-mindependency and implementtoBufferandfromBufferfunctions directly.package.json
osc-mindependency.lib/Client.mjs
toBufferfunction directly in this file.osc-minwith the newtoBufferfunction.lib/internal/decode.mjs
fromBufferfunction directly in this file.osc-minwith the newfromBufferfunction.rollup.config.mjs
osc-minfrom the external dependencies.For more details, open the Copilot Workspace session.