Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get-port and add custom getPort function with tests #117

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

MylesBorins
Copy link
Owner

@MylesBorins MylesBorins commented Jun 5, 2024

Removes the 'get-port' package and replaces its functionality with a custom getPort function in the test/util.mjs file. Adds a new test file to ensure the getPort function works as expected.

  • Removes "get-port" from devDependencies in package.json, eliminating the package from the project.
  • Implements a new getPort function in test/util.mjs using the Node.js net module to find an available port, replacing the previous usage of the get-port package.
  • Adds a new test file test/test-getPort.mjs to verify that the getPort function correctly returns an available port and handles error scenarios, aiming for 100% test coverage.
  • Updates rollup.config.mjs by removing the retainImportExpressionPlugin function and its usage, which was specifically designed to handle dynamic imports of the get-port package, reflecting the removal of get-port from the project.

For more details, open the Copilot Workspace session.

@MylesBorins MylesBorins merged commit f49d10a into main Jun 5, 2024
11 checks passed
@MylesBorins MylesBorins deleted the remove-get-port-1 branch June 5, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant