Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message: add alias ability for type tags #108

Merged
merged 1 commit into from
Jan 22, 2024
Merged

message: add alias ability for type tags #108

merged 1 commit into from
Jan 22, 2024

Conversation

MylesBorins
Copy link
Owner

@MylesBorins MylesBorins commented Jan 22, 2024

Adds the ability to append a message using the short form of the type tag, matching how it will be encoded before going over the wire.

e.g.

message.append({
  type: 'integer', 
  value: 123
});

Prior to this change the above would error.

As this functionality never worked before and wasn't expected I am treating this as a new feature rather than a bug fix.

@MylesBorins MylesBorins linked an issue Jan 22, 2024 that may be closed by this pull request
@MylesBorins MylesBorins merged commit f07acfd into main Jan 22, 2024
11 checks passed
@MylesBorins MylesBorins deleted the message-alias branch January 22, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extend arguments that can be passed to message.append
1 participant