fixup: avoid edge cases of double bound

MylesBorins · Dec 14, 2024 · 1babf99 · 1babf99
1 parent 4cb962a
commit 1babf99
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/lib/Client.mjs b/lib/Client.mjs
@@ -12,12 +12,21 @@ class Client {
       type: 'udp4',
       reuseAddr: true
     });
+    this._bound = false;
   }
-  setBroadcast(flag) {
+  setBroadcast(flag, cb) {
+    if (!cb) cb = () => {};
+    if (this._bound) {
+      this._sock.setBroadcast(flag);
+      cb();
+      return;
+    }
     this._sock.bind(this.port, () => {
+      this._bound = true;
       this._sock.setBroadcast(flag);
-    })
-  }
+      cb();
+     })
+   }
   close(cb) {
     this._sock.close(cb);
   }

diff --git a/test/test-client.mjs b/test/test-client.mjs
@@ -105,6 +105,7 @@ test('client: setBroadcast', (t) => {
   });
 
   client.send(['/test', 0, 1, 'testing', true], (err) => {
+    client.setBroadcast(false);
     t.error(err, 'there should be no error');
     client.close();
   });