Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apr + Delta Finder set as new default instead of RobustHelixFinder + FlagBkgHits #374

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

gianipez
Copy link
Contributor

@gianipez gianipez commented Dec 7, 2024

  • Apr took over RobustHelixFinder
  • DeltaFinder is now the new default for flagging the Compton hits
  • added some missing CalPatRec-based sequences

…ffline default reco + added missing CalPatRec sequences (Upstream and Muon)
@FNALbuild
Copy link
Collaborator

Hi @gianipez,
You have proposed changes to files in these packages:

  • JobConfig

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for cdac7ee: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☔ The build tests failed for cdac7ee.

Test Result Details
test with Command did not list any other PRs to include
merge Merged cdac7ee at 4d289bb
build (prof) Log file. Build time: 04 min 16 sec
ceSimReco Log file. Return Code 9.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO TODO (0) FIXME (0) in 0 files
clang-tidy 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at cdac7ee after being merged into the base branch at 4d289bb.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@gianipez
Copy link
Contributor Author

gianipez commented Dec 7, 2024

@FNALbuild run build test with Mu2e/Offline#1384

@FNALbuild
Copy link
Collaborator

⌛ The following tests have been triggered for 259b718: build (Build queue is empty)

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at 259b718.

Test Result Details
test with Included Mu2e/Offline#1384 @ 43f26128ddc084c269e22f987c352df57455bb59 by merge
merge Merged 259b718 at 4d289bb
build (prof) Log file. Build time: 08 min 34 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO TODO (0) FIXME (0) in 0 files
clang-tidy 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 259b718 after being merged into the base branch at 4d289bb.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@gianipez
Copy link
Contributor Author

gianipez commented Dec 7, 2024

Hi @brownd1978 , I think the PRs are ready (including the Offline and mu2e_trig_config). Feel free to review them at your convenience.

@brownd1978 brownd1978 merged commit f4bae73 into Mu2e:main Dec 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants