Sapphire updates #375
Merged
Sapphire updates #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 99.36% 99.36% -0.01%
==========================================
Files 50 50
Lines 5495 5494 -1
==========================================
- Hits 5460 5459 -1
Misses 35 35
|
This will prevent hangs when a test fails unexpectedly.
Also improve the worker thread cleanup code.
Working to reduce complexity and avoid potential deadlocks. Also increase code coverage and adds docs.
tysmith
force-pushed
the
sapphire-dev
branch
from
3fe3e45
to
fa5cc34
Compare
jschwartzentruber
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the launcher thread and improve worker cleanup code.