Always submit initial results #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
=======================================
Coverage 99.36% 99.36%
=======================================
Files 50 50
Lines 5498 5500 +2
=======================================
+ Hits 5463 5465 +2
Misses 35 35
|
jschwartzentruber
approved these changes
Sep 11, 2023
grizzly/common/status.py
Outdated
| """SELECT pid FROM results WHERE result_id = ?;""", | ||
| (result_id,), | ||
| ) | ||
| unique = cur.fetchone() is None |
There was a problem hiding this comment.
The name unique is not very descriptive. initial or created would be better.
Semantically, unique should still be true when there is one result_id match, not just when the first is created.
When a result is detected for the first time it is always submitted. This can be blocked by the FuzzManager frequent flag. The submission is forced if the result has only been found once (including parallel instances). For subsequent submissions we check if the result is frequent and report accordingly. This takes into account results found by parallel instances.
tysmith
force-pushed
the
submit-unique
branch
from
aedc669
to
7c36e1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a result is detected for the first time it is always submitted. This can be blocked by the FuzzManager frequent flag. The submission is forced if the result has only been found once (including parallel instances). For subsequent submissions we check if the result is frequent and report accordingly. This takes into account results found by parallel instances.