Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for additional services #365

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Add support for additional services #365

wants to merge 34 commits into from

Conversation

pyoor
Copy link
Contributor

@pyoor pyoor commented May 15, 2023 •
edited

Adds support for running additional services during fuzzing, replay, and reduction. This PR also adds a basic WebTransport service.

tysmith
tysmith requested changes May 16, 2023
View reviewed changes
grizzly/replay/replay.py Outdated Show resolved Hide resolved
grizzly/main.py Show resolved Hide resolved
grizzly/session.py Outdated Show resolved Hide resolved
grizzly_services/core.py Outdated Show resolved Hide resolved
grizzly_services/core.py Outdated Show resolved Hide resolved
grizzly_services/webtransport/core.py Outdated Show resolved Hide resolved
grizzly_services/webtransport/core.py Outdated Show resolved Hide resolved
grizzly_services/webtransport/core.py Outdated Show resolved Hide resolved
grizzly_services/webtransport/core.py Outdated Show resolved Hide resolved
grizzly_services/webtransport/test_webtransport.py Outdated Show resolved Hide resolved
jschwartzentruber
jschwartzentruber requested changes May 16, 2023
View reviewed changes
grizzly/replay/replay.py Outdated Show resolved Hide resolved
grizzly_services/core.py Outdated Show resolved Hide resolved
grizzly_services/webtransport/__main__.py Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@pyoor
Copy link
Contributor Author

pyoor commented May 19, 2023

Looks like aioquic is broken on python 3.11 😭

@codecov
Copy link

codecov bot commented May 23, 2023 •
edited

Codecov Report

Merging #365 (5afb00e) into master (57be8fa) will decrease coverage by 0.01%.
The diff coverage is 99.29%.

❗ Current head 5afb00e differs from pull request most recent head 58bc435. Consider uploading reports for the commit 58bc435 to get more accurate results

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
- Coverage   99.36%   99.36%   -0.01%     
==========================================
  Files          50       54       +4     
  Lines        5498     5638     +140     
==========================================
+ Hits         5463     5602     +139     
- Misses         35       36       +1
Impacted Files Coverage Δ
grizzly/services/core.py 97.87% <97.87%> (ø)
grizzly/conftest.py 100.00% <100.00%> (ø)
grizzly/main.py 100.00% <100.00%> (ø)
grizzly/reduce/core.py 94.10% <100.00%> (+0.11%) ⬆️
grizzly/replay/replay.py 100.00% <100.00%> (ø)
grizzly/services/__init__.py 100.00% <100.00%> (ø)
grizzly/services/base.py 100.00% <100.00%> (ø)
grizzly/services/webtransport/core.py 100.00% <100.00%> (ø)
grizzly/session.py 100.00% <100.00%> (ø)
sapphire/__init__.py 100.00% <100.00%> (ø)

pyoor and others added 21 commits October 18, 2023 14:42
@pyoor
wip: initial attempt at adding webtransport to grizzly
71e9330
@tysmith @pyoor
Add dynamic response to provide wt server location
f3ca07b
@pyoor
Initialize port and socket when starting the service.
b1de9df
@pyoor
Apply linter fixes
f26e1a7
@pyoor
Add lambda generator to avoid using lambda directly in loop
7e546c6
@pyoor
fix: lambda expression must accept an argument
6027100
@pyoor
fix: check return code of WebTransport.is_running()
c087dac
@pyoor
test: remove unnecessary iteration of child services
f352688
@pyoor
fix: only log aioquic warnings
8be838a
@pyoor
feat: enable webtransport during reduction
813bc12
@pyoor
feat: enable webtransport during reduction
e4eee0c
@pyoor
feat: replace webtransport server with wpt version
f5b5a27
@pyoor
fix: suppress aioquic logging
c53cabe
@pyoor
feat: improve logging of webtransport is_running check
4263abf
@pyoor
test: add explicit test for WebTransport
649a2a8
@pyoor
refactor: move grizzly_services to grizzly.services
fdc64e4
@pyoor
fix: remove unintentional cli script
508baf6
@pyoor
fix: replace create_cb with lambda that returns a lambda
06a7046
@pyoor
feat: store services as a dict indexed by service name enum
6c407a4
@pyoor
refactor: use 'not' instead of 'is False'
75bd643
@pyoor
feat: export ServiceName enum
0ce01f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tysmith tysmith Awaiting requested review from tysmith

@jschwartzentruber jschwartzentruber Awaiting requested review from jschwartzentruber

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pyoor @jschwartzentruber @tysmith