Recursive testMathyFunction #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the patch! Is this still the case with mozilla-central tip? Bug 1357149 was marked as a dupe of bug 1354273 which is now fixed. Any assertion failure containing [unhandlable oom] is generally intended and signals the system is working as it should - that is, fuzzing has led to a testcase that OOMs in an manner that cannot be handled. If the assertion still shows, then unfortunately I think the idea should be shelved for now, and likewise the issue #91. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the modification to turn testMathyFunction recursive. The variation for each test loop is greatly increased but bugs relating to 1357149 are found very quickly.