fix: handle EOF in user input prompts #1293

romanstingler · 2024-12-15T22:17:42Z

Add proper EOF detection in ask() function
Print " -> EOF" message when EOF is received
Treat EOF as negative response
Handle input read errors explicitly

Morganamilo · 2024-12-27T04:54:05Z

src/util.rs

-        false
+    match stdin.read_line(&mut input) {
+        Ok(0) => {
+            println!(" -> EOF");


Pacman doesn't print anything for this. In fact it doesn't even print a new line.

Paru tries to match pacman when possible so negative on EOF is good but I don't think we should print anything but a new line. Otherwise it kind of messes up the input. I'll see about changing pacman to be like that too.

I agree that this should be handled in Pacman.
Thanks for your time reviewing my stuff and giving feedback.
I will try to get all PRs fixed as soon as possible.

Add proper EOF detection in ask() function Print a new line message when EOF is received Treat EOF as negative response Handle input read errors explicitly closes Morganamilo#1190

Morganamilo reviewed Dec 27, 2024

View reviewed changes

romanstingler force-pushed the eof branch from 0b55927 to 3053acb Compare December 28, 2024 10:01

fix: handle EOF in user input prompts

54e88d7

Add proper EOF detection in ask() function Print a new line message when EOF is received Treat EOF as negative response Handle input read errors explicitly closes Morganamilo#1190

romanstingler force-pushed the eof branch from 3053acb to 54e88d7 Compare December 28, 2024 10:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: handle EOF in user input prompts #1293

fix: handle EOF in user input prompts #1293

romanstingler commented Dec 15, 2024

Morganamilo Dec 27, 2024

romanstingler Dec 28, 2024

fix: handle EOF in user input prompts #1293

Are you sure you want to change the base?

fix: handle EOF in user input prompts #1293

Conversation

romanstingler commented Dec 15, 2024

Morganamilo Dec 27, 2024

Choose a reason for hiding this comment

romanstingler Dec 28, 2024

Choose a reason for hiding this comment