Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Windows 10 support #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dwolner
Copy link

@dwolner dwolner commented May 4, 2016

Worked with a native developer recently to add support for the Windows 10 platform to this plugin. I saw you guys are really needing this so let's merge it in! This is working in development for me, please try it out and let me know your experience.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@dwolner
Copy link
Author

dwolner commented May 4, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@eherve
Copy link

eherve commented Jan 4, 2017

Hi,

Is it possible to know when this merge will be done into the master ?

Thanks
Regards

@troyanskiy
Copy link

Please merge that PR

@Medioman92
Copy link

this should definitely be merged in the master

@agrieve
Copy link
Member

agrieve commented Jul 19, 2017

Sorry for the radio silence here. We don't have a team working on this any more, so it's hard to find time to look at these let alone test PRs. If anyone wants to sign up to maintain a fork, I'd be happy to change the README.md to say "Go use this other one instead".

@whodeee
Copy link

whodeee commented Sep 13, 2017

@dwolner is it possible to get your version with Windows support posted? I and others would appreciate it.

@rdbhagat999
Copy link

Is it merged in the master yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.