Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Fix TCP packet reordering on android, "unknown socket id" on iOS #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mcelrath
Copy link

@mcelrath mcelrath commented Mar 3, 2017

Calling readyToRead as this code does on Android causes TCP packets to be assembled in an incorrect order, resulting in stream data corruption.

However it seems calling readyToRead on iOS is absolutely necessary, or you won't get any data at all.

Fixes #14 and #26

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mcelrath
Copy link
Author

mcelrath commented Mar 3, 2017

I signed it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants