H2T_loadNpy: Add edges of bounding box to mesh structure #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Algiane
added
label: ready to be merged
Algiane
reviewed
Nov 20, 2023
src/inout.c
Outdated
| ref = 0; | ||
| pos = 0; | ||
| for (i=0;i<t[0]-1; ++i) { | ||
| int p0, p1; |
There was a problem hiding this comment.
Is it possible to rename this variables np0 and np1?
It is a detail and this is probably not respected everywhere in the code but I think that it is a good habit to use some naming convention in variables name: p<i> or ppt for point structure or (MMG5_Point) pointers toward point structure (MMG5_pPoint), ip<i> for local point index and np<i> for global point index (int).
It allows an easier understanding for complex or large functions (without having to search or remember what the variable is used for.
There was a problem hiding this comment.
This modification been done as requested.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds the list of ridges of the bounding box to the output mesh when a .npy file is given to hex2tet.
To check the intended behaviour of this new feature, a example is given:
hexa.npy is a file describing a one-hexahedron mesh and tet-from-npy.mesh is the output given by hex2tet.
The output file contains a list of edges and a list of ridges.
example.tar.gz