Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix duplication removal #122

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Conversation

Algiane
Copy link
Member

@Algiane Algiane commented Aug 21, 2024

Sorting points by comparing their coordinates is error prone (see issue #120) and can not be used to avoid a double loop when removing point duplications inside the internal communicator of nodes.

This PR removes the point sort and simply uses a double loop to compare all couple of points stored in the communicator. As the number of points in the communicator is low compared to the number of points in the mesh, it will not be time expensive.

Closes #120

@Algiane Algiane added kind: bug Something isn't working part: parmmg specific to parmmg code part labels Aug 21, 2024
@Algiane Algiane self-assigned this Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.15%. Comparing base (8769e3f) to head (9f838f9).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #122      +/-   ##
===========================================
- Coverage    63.17%   63.15%   -0.03%     
===========================================
  Files           46       46              
  Lines        18968    18960       -8     
  Branches      3546     3546              
===========================================
- Hits         11983    11974       -9     
  Misses        6059     6059              
- Partials       926      927       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algiane Algiane merged commit 535b533 into develop Aug 21, 2024
42 checks passed
@Algiane Algiane deleted the feature/fix_duplication_removal branch August 21, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working part: parmmg specific to parmmg code part
Projects
Development

Successfully merging this pull request may close these issues.

A point shared by at least 2 groups has 2 positions in the internal communicator
1 participant