feat: visitor #53
Open
feat: visitor #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistEO
reviewed
Mar 19, 2024
There was a problem hiding this comment.
visitor 里的接口可以严谨一点参考下其他第三方库，比如 https://pypi.org/project/json-visitor/ ？
include/parser/parser.hpp
Outdated
| private: | ||
| parsing_iter_t _cur; | ||
| parsing_iter_t _end; | ||
|
|
||
| parse_visitor<string_t>* _vis; |
| } | ||
| else { | ||
| return invalid_value<string_t>(); | ||
| } | ||
| } | ||
|
|
||
| if constexpr (has_visitor) { | ||
| _vis->value(basic_value<string_t>(), cur_pos, _pos, _path); |
There was a problem hiding this comment.
就是因为配置了has_visitor的时候强制传入了visitor，所以直接不判空了，从前面的入口处理了
include/parser/parser.hpp
Outdated
| cur_pos = _pos; | ||
| } | ||
| else { | ||
| std::ignore = cur_pos; |
There was a problem hiding this comment.
是不是可以不改原来的函数，而是在外面在包一层 has_visitor=true 特化的 parse_string，这些结构就都放新的里面
There was a problem hiding this comment.
不太确定，不过直接if constexpr简洁一点，特化实在是有点啰嗦
| { | ||
| if constexpr (has_visitor) { | ||
| _pos.offset++; | ||
| if (*_cur == '\n') { |
There was a problem hiding this comment.
这些移动逻辑是直接替换原来的_cur++，原来的各个地方你不是都写了判断的吗（
sample/sample.cpp
Outdated
| @@ -269,6 +341,8 @@ void parsing() | |||
| // it's a std::optional<json::value> | |||
| auto ret = json::parse(content); | |||
|
|
|||
| auto another = json::parse(content, new my_visitor()); | |||
There was a problem hiding this comment.
sample 和文档保持同步，不放不重要的功能。这些都放 test 里。另外这个 new 泄露了
include/parser/parser.hpp
Outdated
| template <typename string_t = default_string_t> | ||
| struct parse_visitor | ||
| { | ||
| using json_path = std::vector<std::variant<string_t, size_t>>; |
|
所以visitor是用来干嘛的 |
|
MistEO
force-pushed
the
master
branch
2 times, most recently
from
430d0a9
to
676cb37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.