Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix binary_support handling #2081

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix binary_support handling #2081

wants to merge 1 commit into from

Conversation

martinv13
Copy link

@martinv13 martinv13 commented Apr 17, 2020 •
edited
Loading

Description

Fix the logic behind binary_support handling in handler.py to allow compressed text response at application level, partially reverting #2029

GitHub Issues

#2080 #2087

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 72.925% when pulling edb3dcf on martinv13:bugfix/fix-binary_support into 80a6881 on Miserlou:master.

@kirkhansen kirkhansen mentioned this pull request Jul 8, 2020
Merged
@snowman2
Copy link
Contributor

snowman2 commented Jul 9, 2020

This solution didn't work for us. We had to revert to the base64 encoding always being on for binary support: corteva#2

@fmarco
Copy link

fmarco commented Jul 22, 2020 •
edited
Loading

@snowman2 i can confirm, yours solution works while this currently not

@jneves jneves mentioned this pull request Feb 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinv13 @coveralls @snowman2 @fmarco