Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenStack provider support with configuration and templates #695

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add OpenStack provider support with configuration and templates #695

wants to merge 1 commit into from

Conversation

bnallapeta
Copy link
Member

@bnallapeta bnallapeta commented Nov 28, 2024 •
edited
Loading

Resolves #594.

OpenStack Provider Integration:

  • Introduces OpenStack as a supported cloud provider in HMC.
  • Adds configurations and provider templates specific to OpenStack environments.

Local Run:

ka get machines
NAME                           CLUSTER         NODENAME                       PROVIDERID                                          PHASE     AGE     VERSION
openstack-dev-cp-0             openstack-dev   openstack-dev-cp-0             openstack:///b52ccc71-566b-4487-a0b8-64b2c08f0e5b   Running   8m29s   v1.30.5+k0s.0
openstack-dev-cp-1             openstack-dev   openstack-dev-cp-1             openstack:///4022efcb-da46-4a99-80f3-2eaf3681238e   Running   8m29s   v1.30.5+k0s.0
openstack-dev-cp-2             openstack-dev   openstack-dev-cp-2             openstack:///87ae87e0-2ac5-4f06-b7ba-970d6dbcab3f   Running   8m29s   v1.30.5+k0s.0
openstack-dev-md-p27j6-6wfn4   openstack-dev   openstack-dev-md-p27j6-6wfn4   openstack:///5c2c51c8-f2c0-48d3-9c8f-ed28db53112a   Running   8m30s   
openstack-dev-md-p27j6-w6qvx   openstack-dev   openstack-dev-md-p27j6-w6qvx   openstack:///2df39a6d-2507-452f-9a0a-fb3e6a5d2052   Running   8m30s   

clusterctl describe cluster openstack-dev -n hmc-system
NAME                                                      READY  SEVERITY  REASON  SINCE  MESSAGE                                                        
Cluster/openstack-dev                                     True                     5m26s                                                                  
├─ClusterInfrastructure - OpenStackCluster/openstack-dev                                                                                                  
├─ControlPlane - K0sControlPlane/openstack-dev-cp                                                                                                         
│ └─3 Machines...                                         True                     7m32s  See openstack-dev-cp-0, openstack-dev-cp-1, ...                 
└─Workers                                                                                                                                                 
  └─MachineDeployment/openstack-dev-md                    True                     110s                                                                   
    └─2 Machines...                                       True                     3m43s  See openstack-dev-md-p27j6-6wfn4, openstack-dev-md-p27j6-w6qvx  

k -n hmc-system get managedclusters.hmc.mirantis.com 
NAME            READY   STATUS
openstack-dev   True    ManagedCluster is ready

@bnallapeta bnallapeta mentioned this pull request Nov 28, 2024
Open
@bnallapeta bnallapeta force-pushed the openstack-add-provider branch 2 times, most recently from ff0b2d1 to 5b2932d Compare November 28, 2024 12:57
@bnallapeta bnallapeta requested a review from eromanova November 28, 2024 12:57
a13x5
a13x5 requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@a13x5 a13x5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird imports should be removed (or moved to another PR).
Minor clarifications are needed.

cmd/main.go Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
templates/provider/cluster-api-provider-openstack/values.yaml Outdated Show resolved Hide resolved
@bnallapeta bnallapeta force-pushed the openstack-add-provider branch from 5b2932d to 9870acf Compare November 28, 2024 15:01
a13x5
a13x5 requested changes Nov 28, 2024
View reviewed changes
templates/provider/cluster-api-provider-openstack/values.yaml Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@bnallapeta bnallapeta force-pushed the openstack-add-provider branch 5 times, most recently from 0493422 to d651ba9 Compare December 3, 2024 12:02
@bnallapeta bnallapeta requested a review from a13x5 December 4, 2024 04:12
eromanova
eromanova reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@eromanova eromanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment from my side. The rest looks good.

config/dev/openstack-managedcluster.yaml Outdated Show resolved Hide resolved
@bnallapeta bnallapeta force-pushed the openstack-add-provider branch 3 times, most recently from dbc1456 to 4ddef40 Compare December 5, 2024 15:23
@bnallapeta
Copy link
Member Author

@a13x5 @eromanova Would appreciate if you can take a look at the PR and merge it soon.

@eromanova
Copy link
Member

@a13x5 @eromanova Would appreciate if you can take a look at the PR and merge it soon.

LGTM. Waiting for Alexey's approval since he also requested changes :)

@ramessesii2 ramessesii2 mentioned this pull request Dec 9, 2024
Open
@a13x5
Copy link
Contributor

a13x5 commented Dec 9, 2024

@bnallapeta @eromanova Let's merge it after airgap fixes will be fully landed.
Meanwhile I believe the cm-ag-resources.yaml file from #687 could be incorporated (no changes in file required) in this PR, since files will be collected, but not used.

a13x5
a13x5 previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@a13x5 a13x5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved
As discussed additional changes/fixes could be added later

@eromanova eromanova force-pushed the openstack-add-provider branch from 4ddef40 to 6e748f2 Compare December 19, 2024 14:20
eromanova
eromanova requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@eromanova eromanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please, address the comment and we can proceed with merging.

templates/provider/hmc-templates/files/templates/cluster-api-provider-openstack.yaml Show resolved Hide resolved
@bnallapeta bnallapeta force-pushed the openstack-add-provider branch from 6e748f2 to d20f702 Compare December 23, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eromanova eromanova eromanova requested changes

@a13x5 a13x5 a13x5 left review comments

@Kshatrix Kshatrix Awaiting requested review from Kshatrix Kshatrix is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Project 2A
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenStack provider template for HMC
3 participants
@bnallapeta @eromanova @a13x5