Hand handling improvement #2142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack.STRICT_NETWORK_TYPE to represent this)
…t to correct drink/eat time from component, send damage event on living entity damage
… are still in ItemComponent)
…ing type. add wolf variant meta field
mworzala
reviewed
May 20, 2024
src/main/java/net/minestom/server/event/player/EntitySwingHandEvent.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Represents the main or off hand of the player. | ||
| */ | ||
| public enum Hand { |
There was a problem hiding this comment.
I think this should stay on Player. Even if it is slightly incorrect (eg for LivingEntity#swingHand to take a Player.Hand), I believe most people will look for player hand. Also makes this change less breaking
There was a problem hiding this comment.
I don't know if it's that breaking, using Player.Hand is still correct. Do you still want this enum to be in a player class?
Codestech1
force-pushed
the
hand-handling-improvement
branch
from
575b59b
to
39badc3
Compare
mworzala
force-pushed
the
1_20_5
branch
2 times, most recently
from
95f7327
to
05a4bb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
EntitySwingHandEventinLivingEntity#swingHand(Hand)method instead of in a packet listener.I think that it would be nice if this pull request was merged, because we could avoid messy code like this.