Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RelativeBlockBatch update #2002

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RelativeBlockBatch update #2002

wants to merge 1 commit into from

Conversation

iam4722202468
Copy link
Member

No description provided.

mworzala
mworzala requested changes Feb 18, 2024
View reviewed changes
Copy link
Member

@mworzala mworzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getBlock should not exist, it exposes internal details and makes it harder to change in the future.

The diff and join methods should be on Batch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mworzala mworzala mworzala requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iam4722202468 @mworzala