Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update using-custom-rewrite-providers-with-url-rewrite-module.md #1069

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

r-V3
Copy link
Contributor

@r-V3 r-V3 commented Oct 21, 2024

@r-V3 r-V3 requested a review from a team as a code owner October 21, 2024 08:07
@wadepickett wadepickett self-assigned this Oct 25, 2024
…rs-with-url-rewrite-module.md


Linked to URL Rewrite 2.1 module as has been suggested previously by IIS team's Sam Wu.
@wadepickett wadepickett self-requested a review October 28, 2024 15:12
Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with link suggestion change.

@wadepickett
Copy link
Contributor

wadepickett commented Oct 28, 2024

Re:
I think it would be better to point the the IIS URL Rewrite 2.1 download page which has valid download links for that >> version, rather than to instruct to install the URL Rewrite Extensibility Samples for 2.0 but not have a link to point them to. >> From what I can discover it looks like those were indeed removed and the 2.1 module is now pointed to instead in some cases.

We can't use the installer copy from the way back machine you pointed to, but thanks for providing the link.

@John-Hart, do you have a different preference for this situation, or happen to know if the URL Rewrite 2.1 samples are still available somewhere. I could not find it.
I did find this public Q&A 2021 note from Sam Wu here:
https://learn.microsoft.com/en-us/answers/questions/438658/link-broken-for-rewriteextensibility-msi-for-url-r

@John-Hart, since this solution follows generally what Sam Wu on the team suggested earlier I will go head and commit and squash. If there is a different preference, let me know and I will change to what you need.

@wadepickett
Copy link
Contributor

Also tracked with and fixes dotnet/AspNetCore.Docs#33954

@wadepickett wadepickett merged commit 4f8b1be into MicrosoftDocs:main Oct 28, 2024
2 checks passed
@wadepickett
Copy link
Contributor

Thanks @r-V3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants