small stylistic improvements

R/calc_APA_factor.R

@@ -21,7 +21,7 @@ calc_APA_factor <- function(pRes, Res){
 
  APAfactor <-
  round(as.numeric(apply(Res, 1, function(x)
- APA[which(names(APA) == x["Source"])])), 2)
+ APA[names(APA) == x["Source"]])), 2)
 
  return(APAfactor)
 

R/checkHTMLdir.R

@@ -9,11 +9,11 @@ checkHTMLdir <- function(dir,
  dir <- tcltk::tk_choose.dir()
  }
 
- if (extension == TRUE) {
+ if (extension) {
  pat = ".html|.htm"
  }
 
- if (extension == FALSE) {
+ if (!extension) {
  pat = ""
  }
 
@@ -31,7 +31,7 @@ checkHTMLdir <- function(dir,
  message("Importing HTML files...")
  pb <- utils::txtProgressBar(max = length(files), style = 3)
 
- for (i in 1:length(files)) {
+ for (i in seq_along(files)) {
  txts[i] <- getHTML(files[i])
  utils::setTxtProgressBar(pb, i)
  }

R/checkPDFdir.R

@@ -22,7 +22,7 @@ checkPDFdir <-
  message("Importing PDF files...")
  pb <- utils::txtProgressBar(max = length(files), style = 3)
 
- for (i in 1:length(files)){
+ for (i in seq_along(files)){
  txts[i] <- getPDF(files[i])
  utils::setTxtProgressBar(pb, i)
  }

R/checkdir.R

@@ -21,30 +21,30 @@ checkdir <-
  if (htmls)
  htmlres <- checkHTMLdir(dir, subdir, ...)
 
- if (pdfs & htmls) {
+ if (pdfs && htmls) {
  if (!is.null(pdfres) & !is.null(htmlres))
  Res <- rbind(pdfres, htmlres)
  else
  stop("statcheck did not find any results")
 
  } else
- if (pdfs & !htmls) {
+ if (pdfs && !htmls) {
  if (!is.null(pdfres))
  Res <- pdfres
  else
  stop("statcheck did not find any results")
  }
 
  else
- if (!pdfs & htmls) {
+ if (!pdfs && htmls) {
  if (!is.null(htmlres))
  Res <- htmlres
  else
  stop("statcheck did not find any results")
  }
 
  else
- if (!pdfs & !htmls)
+ if (!pdfs && !htmls)
  stop("No PDF or HTML found")
 
 

R/decision_error_test.R

@@ -9,7 +9,7 @@ decision_error_test <- function(reported_p, computed_p,
  # check errors for different combinations of <>= -------------------------
 
  # treat p = alpha as significant
- if(pEqualAlphaSig == TRUE){
+ if(pEqualAlphaSig){
  if(test_comparison == "="){
 
  if(p_comparison == "="){
@@ -73,7 +73,7 @@ decision_error_test <- function(reported_p, computed_p,
  return(NA)
 
  # treat p = alpha as significant
- } else if (pEqualAlphaSig == FALSE){
+ } else if (!pEqualAlphaSig){
 
  if(test_comparison == "="){
 

R/error_test.R

@@ -44,7 +44,7 @@ error_test <- function(reported_p, test_type, test_stat,
 
  # p values smaller or equal to zero are errors ---------------------------
 
- if(pZeroError == TRUE & reported_p <= 0){
+ if(pZeroError && reported_p <= 0){
  error <- TRUE
  return(error)
  }

R/plot.statcheck.R

@@ -57,7 +57,7 @@ plot.statcheck <- function(
  x[[VAR_P_COMPARISON]][ns] <- ">"
  x[[VAR_REPORTED_P]][ns] <- alpha
 
- if (APAstyle == TRUE) {
+ if (APAstyle) {
 
  # Add vector "Type" to statcheck object, specifying whether observations are
  # correctly reported, reporting inconsistencies, or decision errors.

R/process_stats.R

@@ -51,7 +51,7 @@ process_stats <- function(test_type, test_stat, df1, df2, reported_p,
  # tailed test, classify the result as consistent
  # don't apply this correction if OneTailedTests == FALSE, because this already
  # forces statcheck to treat all results as one-tailed tests
- if(OneTailedTxt == TRUE & OneTailedTests == FALSE){
+ if(OneTailedTxt && !OneTailedTests){
 
  # select only results where the phrase "one-tailed", "one-sided" or
  # "directional" was mentioned in text, and that were an error when

R/statcheck.R

@@ -142,7 +142,7 @@ statcheck <- function(texts,
  # progress bar. This is mainly useful for the unit tests; otherwise hundreds
  # of progress bars would be printed during testing and that makes the test 
  # results hard to read
- if(messages == TRUE){
+ if(messages){
  message("Extracting statistics...")
  pb <- utils::txtProgressBar(max = length(text), style = 3)
  }
@@ -195,14 +195,14 @@ statcheck <- function(texts,
  rm(nhst)
 
  # update the progress bar
- if(messages == TRUE){
+ if(messages){
  utils::setTxtProgressBar(pb, i)
  }
 
  }
 
  # close progress bar
- if(messages == TRUE){
+ if(messages){
  close(pb)
  }
 
@@ -215,11 +215,8 @@ statcheck <- function(texts,
  # same as the automated 1-tailed test detection (switched on with the 
  # argument: OneTailedTxt). The latter works more subtly (see comments in 
  # process_stats()). 
- if (OneTailedTests == TRUE) {
- two_tailed <- FALSE
- } else {
- two_tailed <- TRUE
- }
+ two_tailed <- !OneTailedTests
+
 
  # create empty variables to fill out during the loop
  Res$Computed <- rep(NA, nrow(Res))
@@ -279,7 +276,7 @@ statcheck <- function(texts,
 
  # Return ------------------------------------------------------------------
 
- if (AllPValues == FALSE) {
+ if (!AllPValues) {
 
  # Return message when there are no results
  if (nrow(Res) > 0) {