feat(Youtube): Add support for height & width options #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #151 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 16 -1
Lines 300 220 -80
Branches 95 29 -66
=========================================
- Hits 300 220 -80
Continue to review full report at Codecov.
|
|
TravisCI seems to have failed on |
seanmcn
added a commit
to seanmcn/my-website
that referenced
this pull request
Oct 31, 2020
…nge the height of the videos when MichaelDeBoey/gatsby-remark-embedder#151 is merged.
seanmcn
added a commit
to seanmcn/my-website
that referenced
this pull request
Oct 31, 2020
…nge the height of the videos when MichaelDeBoey/gatsby-remark-embedder#151 is merged.
|
Any news about this PR? I'd really need this feature... |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Adds support for passing height & width to the YouTube Transformer.
Why: Makes the transformer more customisable, not everyone wants their videos 100% wide and 315px high? 🤣 Requested by someone else in #144 and is something I require.
How: In the same way as #146
Checklist: