Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fetchurl with --version-regex #313

Merged
merged 1 commit into from
Jan 4, 2025
Merged

fix fetchurl with --version-regex #313

merged 1 commit into from
Jan 4, 2025

Conversation

DimitarNestorov
Copy link
Contributor

When using --version-regex on a package the fetches source via fetchurl the update failed because package.rev was None

@Mic92
Copy link
Owner

Mic92 commented Jan 4, 2025

@mergify queue

@Mic92
Copy link
Owner

Mic92 commented Jan 4, 2025

Thanks!

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 4, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = tests
        • check-skipped = tests
        • check-success = tests
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Mic92
Mic92 reviewed Jan 4, 2025
View reviewed changes
nix_update/update.py Outdated Show resolved Hide resolved
@Mic92 Mic92 force-pushed the fetchurl-with-version-regex branch from f74cf98 to 5577446 Compare January 4, 2025 08:59
@Mic92
Copy link
Owner

Mic92 commented Jan 4, 2025

@mergify queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 4, 2025 •
edited
Loading

queue

☑️ The pull request will automatically be requeued

Merge queue reset: an external action moved the base branch head to b13ad79

@Mic92
Copy link
Owner

Mic92 commented Jan 4, 2025

@mergify refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 4, 2025

refresh

✅ Pull request refreshed

@Mic92 Mic92 merged commit b13ad79 into Mic92:main Jan 4, 2025
3 checks passed
This was referenced Jan 5, 2025
Closed
Closed
@liff liff mentioned this pull request Jan 5, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitarNestorov @Mic92