-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new Composer builder #283
Conversation
Just run |
5de717a
to
14c8b68
Compare
now only the composer test fails. |
Hmm, I tested both versions manually to verify it works. I can't seem to figure out what's wrong with the test though. It's probably something silly. Do you have an idea? |
The current nixpkgs is quite old and doesn't have php.buildComposerProject2, which is needed for PR Mic92#283
It was indeed silly ^^. The nixpkgs was too old and didn't have |
@mergify rebase |
✅ Branch has been successfully rebased |
14c8b68
to
2278b7d
Compare
@mergify queue |
🛑 The pull request has been merged manuallyThe pull request has been merged manually at d033f05 |
Did something break, or is this normal mergify behaviour? I have no idea, just curious. |
I don't know the conditions are met as far as I can see. |
@patka-123 Maybe using composer1 instead of composer-old would be more appropriate as there will be coming more versions in the future. But maybe the time to change that is when composer 3 is released. |
I followed the go example that is already present in this repo. And I'm not sure what you mean specifically. This isn't about composer itself, but the Even in the worst case we somehow end up with 3 seperate versions of |
Gotcha, I thought it's composer1/composer2 related, but if it's only the derivation builder of course my comment doesn't apply. Thanks for clarifying. |
A new version of
buildComposerProject
has been introduced. Updating packages that use this new version with nix-update failed to update thevendorHash
before this PR.