Skip to content
This repository has been archived by the owner on Mar 14, 2019. It is now read-only.

Fixing issue 731 & 408 #914

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

louis49
Copy link

@louis49 louis49 commented Jan 22, 2016

No description provided.

@YannDanthu
Copy link

+1

@ChrisCinelli
Copy link
Contributor

Does this fix #725 too?
This was definitely where it was crashing: https://github.com/CollectionFS/Meteor-CollectionFS/pull/914/files#diff-3a71c936b7fa3ece7c136a01afc0d6a3L297

// Get updated chunkCount
var chunkCount = FS.Utility.size(tracker.findOne(selector).keys);
var chunkCount = FS.Utility.size(temp.keys);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is pretty straight forward. What is unclear is when we get in the condition where temp is empty. @louis49 do you have something to add here?

@ericoe
Copy link

ericoe commented May 12, 2017

Hey guys, what is the status on this? Looks like the pull request was never approved. Are you running this code with success?

@nooitaf
Copy link
Contributor

nooitaf commented Dec 4, 2017

This seems to be about sharding and multinode setups?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants