Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v11.15.5 #24528

Merged
merged 4 commits into from
May 15, 2024
Merged

v11.15.5 #24528

merged 4 commits into from
May 15, 2024

Conversation

danjm
Copy link
Contributor

@danjm danjm commented May 14, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [d2aca80]
Page Load Metrics (874 ± 588 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint701871103014
domContentLoaded115027105
load5232048741226588
domInteractive115027105

dbrans and others added 3 commits May 14, 2024 19:42
… into v11.15.5 (#24530)

Cherry-pick feat: Slightly update UI for the STX Opt In modal
527f12c (#24525) in into v11.15.5.

Merged cleanly. There were no merge conflicts.

Co-authored-by: Daniel <[email protected]>
@metamaskbot
Copy link
Collaborator

Builds ready [f28fbae]
Page Load Metrics (898 ± 536 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint701791022914
domContentLoaded106227178
load5825958981117536
domInteractive106227178

@danjm danjm marked this pull request as ready for review May 15, 2024 17:26
@danjm danjm requested a review from a team as a code owner May 15, 2024 17:26
@danjm danjm merged commit 477bb6d into master May 15, 2024
71 of 72 checks passed
@danjm danjm deleted the Version-v11.15.5 branch May 15, 2024 17:29
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants