Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codeowners): Remove brad-decker #24521

Merged
merged 3 commits into from
May 16, 2024

Conversation

brad-decker
Copy link
Contributor

@brad-decker brad-decker commented May 14, 2024

Description

Remove myself as a code-owner on the extension.

Related issues

None

Manual testing steps

No changes

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.37%. Comparing base (c6f9b01) to head (afe99d3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24521   +/-   ##
========================================
  Coverage    67.37%   67.37%           
========================================
  Files         1289     1289           
  Lines        50213    50213           
  Branches     13005    13005           
========================================
  Hits         33827    33827           
  Misses       16386    16386           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brad-decker brad-decker merged commit 0ac312c into develop May 16, 2024
71 of 72 checks passed
@brad-decker brad-decker deleted the chore/remove-codeowner-and-mentions branch May 16, 2024 03:03
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [afe99d3]
Page Load Metrics (590 ± 435 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5713588178
domContentLoaded8481594
load462254590906435
domInteractive8481594
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants