Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Numbers network and token icons #24508

Merged
merged 1 commit into from
May 30, 2024

Conversation

shc261392
Copy link
Contributor

Description

Add Numbers Protocol mainnet network icon and token icon support.

Related issues

Fixes: N/A

Manual testing steps

  1. Go to Numbers Mainnet Explorer
  2. Scroll down to bottom and click the Metamask icon to add network
  3. Open Metamask extension to check the network and token icons

Screenshots/Recordings

Before

截圖 2024-05-14 下午1 22 26

After

截圖 2024-05-09 下午4 46 02

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented May 14, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@shc261392
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@shc261392 shc261392 marked this pull request as ready for review May 14, 2024 05:33
@shc261392 shc261392 requested a review from a team as a code owner May 14, 2024 05:33
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.77%. Comparing base (3d861ca) to head (2f605ce).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24508      +/-   ##
===========================================
- Coverage    65.77%   65.77%   -0.00%     
===========================================
  Files         1366     1366              
  Lines        54255    54257       +2     
  Branches     14102    14102              
===========================================
+ Hits         35685    35686       +1     
- Misses       18570    18571       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bergeron bergeron merged commit 5f2bcbf into MetaMask:develop May 30, 2024
72 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants