-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rpc router section to SIP-26 #151
Open
adonesky1
wants to merge
27
commits into
main
Choose a base branch
from
ad/sip-26/add-rpc-router-details
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+516
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gustavo Antunes <[email protected]>
Co-authored-by: Charly Chevalier <[email protected]>
adonesky1
force-pushed
the
ad/sip-26/add-rpc-router-details
branch
from
October 11, 2024 14:01
e50d6cb
to
051318f
Compare
adonesky1
force-pushed
the
ad/sip-26/add-rpc-router-details
branch
from
October 11, 2024 14:08
051318f
to
2e1d94c
Compare
adonesky1
force-pushed
the
ad/sip-26/add-rpc-router-details
branch
from
October 11, 2024 14:29
953910b
to
e084b41
Compare
adonesky1
force-pushed
the
ad/sip-26/add-rpc-router-details
branch
from
October 18, 2024 20:52
7557007
to
8eca4a6
Compare
…ent method signatures
adonesky1
force-pushed
the
ad/sip-26/add-rpc-router-details
branch
from
October 18, 2024 20:53
8eca4a6
to
9b69ce1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds further detail to the RPC Router:
RPC Router
The RPC Router is a native wallet component responsible for routing RPC requests made via the Multichain API to either a Protocol Snap or the Account Router, depending on whether the requested method is registered as a signing method or not.
Role and Functioning
Initial Request Handling: Receives all incoming RPC requests made via the Multichain API that do not have an
eip155
namespace. For now,eip155
scoped requests will continue to be handled by the native wallet, though we will need to consider how to allow users to decide whether to route these requests to snaps as well in the future.Method Registration: Provides entry points for the Account Router and Protocol Snaps to register their methods, method signatures, and scopes, and maintains a registry of these RPC methods and their respective handlers.
Request Routing: Uses the internal registry to determine the correct handler for each incoming RPC request based on the method name, method signatures, and scope strings, forwarding the request to either the Account Router or the appropriate Protocol Snap.
See the diff for more!