fixes #3654 - NumericUpDown not focusable by pressing tab

[corvinsz]

set IsTabStop to False on the default NumericUpDown control style

[corvinsz]

removed setting IsTabStop again.
Instead added an eventhandler for GotFocusEvent to move the focus to the PART_TextBox when the NumericUpDown has gotten focus.

When the control gets focused, all the text of the PART_TextBox gets selected via SelectAll(). It's debatable if that should be a thing or not. I decided to go with it because that's how the default WPF DatePicker handles it.

[Keboo]

Though I typically like this SelectAll behavior on my apps I am hesitant to add it to the control by default. What about simply adding a new SelectAll method to this control so that apps can call it if they want that behavior?

[corvinsz]

Yes, as I stated above it's debatable if SelectAll should be called inside of the event handler or not.
I guess with your suggestion we get the best of both worlds.

[Keboo]

Hey @corvinsz, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #3656

#3656

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

[github-actions]

This PR is marked stale because it has been open 60 days with no activity. Remove stale label or update the PR, otherwise it will be closed in 14 days.