Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support semantic highlight, introduced in specification 3.16.0 #805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MaskRay
Copy link
Owner

@MaskRay MaskRay commented Jun 6, 2021

No description provided.

@codeinred
Copy link

Should this be closed now that semantic highlighting has been added, or is there still work to be done?

@raiguard
Copy link

raiguard commented Aug 26, 2021

As far as I can tell, CCLS's current semantic highlighting support is not part of the LSP spec. That's what this PR is for - to add support for the actual LSP semantic tokens spec.

My editor only supports the LSP spec version of semantic highlighting, so I can't use it at all until this is merged. Unless I want to get my hands dirty and build from source...

@AkibAzmain
Copy link

AkibAzmain commented Feb 17, 2022

It merges successfully and works! (Tested with Emacs and lsp-mode.)

However, the buffer must be changed to see the effects.

@AkibAzmain
Copy link

AkibAzmain commented Feb 22, 2022

It merges successfully and works...

... but not well. There are several problems:

  • textDocument/semanticToken/range doesn't work with multi-line ranges.
  • Returns tokens for a old version of the file in question (maybe a version from its cache).
  • It declares that textDocument/semanticToken/full/delta is supported, but the method is unusable as textDocument/semanticToken/full doesn't give a resultId.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants