Fix test hanging in MultiQueueWaiter destructor && allow it to run with clang >= 6.0.0 #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add WorkDoneProgress to represent WorkDoneProgressBegin/WorkDoneProgressReport/WorkDoneProgressEnd.
std::condition_variable_any destructor is only safe to invoke if all threads have been notified. Reference: https://en.cppreference.com/w/cpp/thread/condition_variable_any/%7Econdition_variable_any Signed-off-by: Ernest Borowski <[email protected]>
Signed-off-by: Ernest Borowski <[email protected]>
xerrni
changed the title
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
ee29996
to
feb153a
Compare
MaskRay
force-pushed
the
master
branch
9 times, most recently
from
94ba2b3
to
c018bce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fixes ccls hanging in MultiQueueWaiter destructor during test execution.
Second one enables tests execution when clang version >= 6.0.0.