Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make 'pause after song' work #3565

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Glench
Copy link

@Glench Glench commented May 18, 2019

fixes #3383

There may be a further issue with change:track being fired twice that warrants looking into.

@welcome
Copy link

welcome bot commented May 18, 2019

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line: - Run npm run lint locally to catch formatting errors earlier. - Include tests when adding/changing behavior. - Include screenshots and animated GIFs whenever possible. - If you added new translation strings ensure that you have added empty strings for all languages - If you added new functionality or modified existing functionality please ensure it is tested

@Glench
Copy link
Author

Glench commented May 18, 2019

I opened an issue on the potential change:track bug here: gmusic-utils/gmusic.js#24

@Glench
Copy link
Author

Glench commented Aug 6, 2019

@MarshallOfSound any word on getting this merged?

@JustACuteGirlLookingForAManToFixHerBugs

Hopefully this can be revived

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Pause after this song" doesn't seem to be working
4 participants