Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for sharding #768

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Remove support for sharding #768

merged 2 commits into from
Feb 24, 2023

Conversation

AliyanH
Copy link
Member

@AliyanH AliyanH commented Feb 23, 2023

@AliyanH
Copy link
Member Author

AliyanH commented Feb 24, 2023

@prushforth
Copy link
Member

I am not sure if this code is linked to sharding or not:

https://github.com/Maps4HTML/Web-Map-Custom-Element/blob/0e006d230b3726b8f2c40c7c749f444b1068d0b1/src/mapml/layers/TemplatedTileLayer.js#L170-L174

No. It tests to see if there are any variables in the URL template that aren't part the parameters required to obtain a tile i.e. the row/col/zoom or the tile's extent coordinates (left/right/top/bottom). If such a variable exists, it's name is made a member of the variables who's value will be generated via controls in the layer control e.g. time select or something like that.

@prushforth
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants