Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topoplot series, fresh base #3

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Topoplot series, fresh base #3

wants to merge 30 commits into from

Conversation

behinger
Copy link
Collaborator

@behinger behinger commented Jun 30, 2022

this replaces #2, now with better history.

Also docstring + tests for the binning added.

Docstring for eeg_topoplot_series (rename!) was added as well + example

  • add eeg_topoplot_series testcase

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #3 (9c03afb) into master (9ad8f41) will increase coverage by 0.49%.
The diff coverage is 86.27%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   84.35%   84.84%   +0.49%     
==========================================
  Files           5        6       +1     
  Lines         147      198      +51     
==========================================
+ Hits          124      168      +44     
- Misses         23       30       +7     
Impacted Files Coverage Δ
src/TopoPlots.jl 100.00% <ø> (ø)
src/eeg.jl 90.32% <ø> (ø)
src/eeg-series.jl 86.27% <86.27%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@behinger
Copy link
Collaborator Author

behinger commented Jul 14, 2022

I discussed with @palday last week. He is greatly in favour of removing AlgebraOfGraphics.jl as a dependency.

To do so, we'd need to set out the grid ourselfs.
I think the following two modes are important:

row-wise with multiple rows possible

1 2 3 4 5 6
A B C D E F

continuous

1 2 3
4 5 6 
7 8 9

@behinger
Copy link
Collaborator Author

image
I added consistent levels + colormaps to the topoplots. Before each topoplot had an independent colormap + countour level

@behinger behinger requested review from palday and removed request for SimonDanisch August 9, 2022 11:39
@behinger
Copy link
Collaborator Author

behinger commented Sep 3, 2022

hey - if this is not the right place for this tool, then I can simply include it in UnfoldMakie.jl - I just need to know :)

@SimonDanisch
Copy link
Member

No, I think this is the right place! :) Just didn't have a lot of time to review before the basics weren't working...
Will try to review today!

# for topoplot_series
using DataFrames
using CategoricalArrays

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove DataFrames, but I need CategoricalArrays for the cut function

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked, it wont be easy to remove all of DataFrames functionality (most importantly the functionality of stack),

@behinger
Copy link
Collaborator Author

behinger commented Dec 1, 2022

Hi!
there is really no issue to take this into UnfoldMakie.jl - but this is now open for review for ~3 month...

Should I just take it to UnfoldMakie.jl until this is reviewed? I will do this tomorrow. I can always remove it again when this is merged.

@palday
Copy link
Collaborator

palday commented Dec 1, 2022

@behinger the big blocker at the moment is moving away from the DataFrames-based API. I can do this rewrite, but don't have time at the moment. So I guess put it in UnfoldMakie and when we get this integrated here, then you can change UnfoldMakie to just call the functionality here. Thanks for the contribution and sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants