-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topoplot series, fresh base #3
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 84.35% 84.84% +0.49%
==========================================
Files 5 6 +1
Lines 147 198 +51
==========================================
+ Hits 124 168 +44
- Misses 23 30 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I discussed with @palday last week. He is greatly in favour of removing AlgebraOfGraphics.jl as a dependency. To do so, we'd need to set out the grid ourselfs. row-wise with multiple rows possible
continuous
|
hey - if this is not the right place for this tool, then I can simply include it in UnfoldMakie.jl - I just need to know :) |
No, I think this is the right place! :) Just didn't have a lot of time to review before the basics weren't working... |
# for topoplot_series | ||
using DataFrames | ||
using CategoricalArrays | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove DataFrames, but I need CategoricalArrays for the cut
function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked, it wont be easy to remove all of DataFrames functionality (most importantly the functionality of stack
),
Hi! Should I just take it to UnfoldMakie.jl until this is reviewed? I will do this tomorrow. I can always remove it again when this is merged. |
@behinger the big blocker at the moment is moving away from the DataFrames-based API. I can do this rewrite, but don't have time at the moment. So I guess put it in UnfoldMakie and when we get this integrated here, then you can change UnfoldMakie to just call the functionality here. Thanks for the contribution and sorry for the delay! |
this replaces #2, now with better history.
Also docstring + tests for the binning added.
Docstring for eeg_topoplot_series (rename!) was added as well + example