Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3252 #3254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #3252 #3254

wants to merge 1 commit into from

Conversation

nextgens
Copy link
Contributor

What type of PR?

bug-fix

What does this PR do?

Ensure that sending emails to invalid addresses with an '@' in localpart is permanently and not temporarily rejected.

This is the sister commit of 15569c6

Related issue(s)

Prerequisites

Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

  • In case of feature or enhancement: documentation updated accordingly
  • Unless it's docs or a minor change: add changelog entry file.

@nextgens nextgens added priority/p2 Minor bug / Could have type/bug Bug. Not working as intended type/backport Automatic backport this PR to the current stable release labels May 10, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 10, 2024

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors-mailu bot added a commit that referenced this pull request May 10, 2024
@bors-mailu
Try #3254:
f26b569
@nextgens
Copy link
Contributor Author

nextgens commented May 10, 2024 •
edited

We should probably have tests for 'exotic'/invalid addresses ; I am not sure how to test this properly; creating a new domain will exercise different code paths from what a remote delivery would be.

Thoughts?

@nextgens nextgens added this to the 2024.x milestone May 10, 2024
@bors-mailu
Copy link
Contributor

bors-mailu bot commented May 10, 2024

try

Build succeeded:

@nextgens nextgens mentioned this pull request May 10, 2024
Open
@nextgens nextgens added the status/wip Work in progress. This will block mergify until the label is removed. label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostwheel42 ghostwheel42 Awaiting requested review from ghostwheel42

@Diman0 Diman0 Awaiting requested review from Diman0

Assignees
No one assigned
Labels
priority/p2 Minor bug / Could have status/wip Work in progress. This will block mergify until the label is removed. type/backport Automatic backport this PR to the current stable release type/bug Bug. Not working as intended
Projects
None yet
Milestone
2024.x
Development

Successfully merging this pull request may close these issues.

Double @ Sign In Sent Email Causing Rate Limiting
1 participant
@nextgens