Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use redis as IMAP- and session-cache #2944

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sholl
Copy link
Contributor

@sholl sholl commented Sep 16, 2023

What type of PR?

Feature

What does this PR do?

This PR uses the already used redis-deployment for storing roundcube IMAP- and session-cache in order to speed up the Web-UI of roundcube.

Related issue(s)

Prerequisites

Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

  • [X ] In case of feature or enhancement: documentation updated accordingly
  • Unless it's docs or a minor change: add changelog entry file.

@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2023

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors bot added a commit that referenced this pull request Sep 16, 2023
@sholl sholl marked this pull request as ready for review September 16, 2023 07:59
@bors
Copy link
Contributor

bors bot commented Sep 16, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@nextgens
Copy link
Contributor

I don't want to sound obnoxious but have you tested it? What performance improvement is expected here?

My take is that it can't possibly work as is since the redis container is on the "default" network which is unreachable from the "webmail" network.

@sholl
Copy link
Contributor Author

sholl commented Sep 16, 2023

I don't want to sound obnoxious but have you tested it? What performance improvement is expected here?

Yes, I have tested this on my live-system, but with a slightly different network setup, so your hint with default-network is helpful. My redis-cluster runs in the default network, webmail as well.
I should reread the docs for testing changes locally...

My take is that it can't possibly work as is since the redis container is on the "default" network which is unreachable from the "webmail" network.

right.
You can decide what will be best for the project. Adopt this PR (perhaps also add redis to the webmail-network), or skip it entirely, since it can be (easily) added to the roundcube-config via the overrides. I could also add a hint in the docs

What is your preference?

@nextgens
Copy link
Contributor

I personally think that documentation would be better. This is useful/required if you "scale up" the number of webmail instances... which arguably we do not support.

I remain to be convinced that on a single instance deployment it significantly changes anything.

@Deltachaos
Copy link

I am interested in this as well as it will increase HA adoption

Copy link
Contributor

mergify bot commented Feb 22, 2024

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

@bors-mailu
Copy link
Contributor

bors-mailu bot commented Feb 22, 2024

try

Merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use redis from within roundcube webmail
5 participants