Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #117

Closed
wants to merge 1 commit into from
Closed

Update dependencies #117

wants to merge 1 commit into from

Conversation

Yfke
Copy link

@Yfke Yfke commented Dec 28, 2023

Due to its very specific dependency requirements (exactly equal to specific subversions), this library is starting to become incompatible with other libraries in the ML space. I propose to follow the convention of only requiring a specific major version, and allowing the package manager freedom to decide on the minor version. I don't see specific reasons why OCTIS is not compatible with higher minor versions of gensim, scikit-learn and numpy.

@Yfke
Copy link
Author

Yfke commented Feb 21, 2024

Thank you for reviewing and approving these changes. I do not have write access to this repo, so I cannot perform the merge myself.

@alex-spok
Copy link

I am also facing an issue with the dependencies, and this PR seems to solve them. I think it would solve #114 as well.
@silviatti, if you have a moment, can you have a look and merge it?
Thanks a lot!

@1jamesthompson1
Copy link

Speaking up again to sa that I am facing this issue and merging this PR would be really helpful!
@silviatti or @pietrotrope could you please have a look at this.

I excited to be able to try this properly in my project.

@alihashaam
Copy link

@silviatti or @pietrotrope

Can we please merge this PR?

@silviatti
Copy link
Collaborator

Hey everyone, thank you for your patience. I couldn't merge this PR because the tests were failing. However, I have fixed the dependencies in a separate branch and merged this into master today (pip install octis==1.14.0 should do the trick). Please let me know if have any issues with the dependencies and I'll try to address them. Finding the right combination wasn't trivial :) I'll close this PR for now

@silviatti silviatti closed this Jul 22, 2024
@bugbyte42
Copy link

bugbyte42 commented Dec 4, 2024

Did this really end up fixing dependency issues for everyone? Still seeing related w/ python 3.12.7 even while installing octis==1.14.0, specifically:

AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?

which I had seen Yfke's PR specifically mentioned as addressing; definitely won't have ImpImporter anymore with 3.12..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants