Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for SAMD devices #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ilcato
Copy link

@ilcato ilcato commented Jun 6, 2018

Fixes # or Enhancement #

Changes proposed in this pull request:

  • Added support for SAMD based devices like MKR family. Tested on a MKR1000

Contributors: ilcato

@Blind228
Copy link

Just tested this fork from ilcato on a Arduino MKR WIFI 1010 and it works great. Fixes the "PluggableUSB.h not found" error I was having.

@takigama
Copy link

tested with seeed xiao and works on that as well.

@alphaleonis
Copy link

Rebased this onto the main branch and tested with an Adafruit Trinket M0. Seems to work great. :) (How come these PR:s never seem to get merged?) :(

@MHeironimus
Copy link
Owner

@alphaleonis asked:

How come these PR:s never seem to get merged?

Because I don't have time to test them. :)

Seriously though, I do appreciate people's contribution. Once a PR is created, people can use the PR version if they have that particular hardware. Once a PR is merged to master, there is an expectation that it is "supported". That means I need to test it well enough that I feel comfortable "supporting it", and that can take a lot of time.

@alphaleonis
Copy link

Because I don't have time to test them. :)

Ah, I understand. Supporting and testing for all different hardware out there of course would require a very large effort. Just having the PR here solved the problem for me anyway, so I'm happy. :)

@relaxibus
Copy link

tested with seeed xiao and works on that as well.

What Xiao module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants