Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/xcode 16 and swift 6 fixes #19

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

roanutil
Copy link
Member

  • Fix manifest for Xcode 16/Swift 6
  • Require MockOutput conform to Sendable

roanutil added 2 commits June 13, 2024 10:16
feature/xcode-16-and-swift-6-fixes
feature/xcode-16-and-swift-6-fixes
… github macos-14 runners)

feature/xcode-16-and-swift-6-fixes
feature/xcode-16-and-swift-6-fixes
feature/xcode-16-and-swift-6-fixes
feature/xcode-16-and-swift-6-fixes
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.62%. Comparing base (0125c10) to head (49e48b2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   74.85%   75.62%   +0.77%     
==========================================
  Files          24       24              
  Lines         684      517     -167     
==========================================
- Hits          512      391     -121     
+ Misses        172      126      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-jarvis
Copy link
Collaborator

@roanutil Was the goal of this PR to fix all Swift 6 strict concurrency warnings? I am getting a few Capture of 'scheduler' with non-sendable type 'T' in a '@Sendable' closure warnings as well as one Capture of 'mock' with non-sendable type 'MockNetworkService<AnySchedulerOf<DispatchQueue>>' in the tests.

Will approve if that wasn't the scope of this.

@roanutil
Copy link
Member Author

@roanutil Was the goal of this PR to fix all Swift 6 strict concurrency warnings? I am getting a few Capture of 'scheduler' with non-sendable type 'T' in a '@Sendable' closure warnings as well as one Capture of 'mock' with non-sendable type 'MockNetworkService<AnySchedulerOf<DispatchQueue>>' in the tests.

Will approve if that wasn't the scope of this.

No, this PR is only to fix package resolution or build errors. There's still Sendability warnings

@r-jarvis r-jarvis merged commit 5f8547b into main Jun 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants