-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/xcode 16 and swift 6 fixes #19
Conversation
roanutil
commented
Jun 13, 2024
- Fix manifest for Xcode 16/Swift 6
- Require MockOutput conform to Sendable
feature/xcode-16-and-swift-6-fixes
feature/xcode-16-and-swift-6-fixes
… github macos-14 runners) feature/xcode-16-and-swift-6-fixes
feature/xcode-16-and-swift-6-fixes
feature/xcode-16-and-swift-6-fixes
feature/xcode-16-and-swift-6-fixes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 74.85% 75.62% +0.77%
==========================================
Files 24 24
Lines 684 517 -167
==========================================
- Hits 512 391 -121
+ Misses 172 126 -46 ☔ View full report in Codecov by Sentry. |
@roanutil Was the goal of this PR to fix all Swift 6 strict concurrency warnings? I am getting a few Will approve if that wasn't the scope of this. |
No, this PR is only to fix package resolution or build errors. There's still Sendability warnings |