Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPTypes #17

Merged
merged 2 commits into from
Apr 19, 2024
Merged

HTTPTypes #17

merged 2 commits into from
Apr 19, 2024

Conversation

roanutil
Copy link
Member

@roanutil roanutil commented Apr 3, 2024

Breaking changes for future major release

Change API to use HTTPTypes instead of Foundation types.

Starting a request still uses URLSession and URLRequest because of some unexpected behavior when starting a HTTPRequest directly.

…rename NetworkService.Failure to NetworkServiceError

swift-http-types
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 68.80000% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 74.85%. Comparing base (778c696) to head (0125c10).

Files Patch % Lines
...es/NetworkService/NetworkServiceClient+Start.swift 52.63% 18 Missing ⚠️
Sources/NetworkService/NetworkServiceError.swift 0.00% 14 Missing ⚠️
...erviceTests/NetworkServiceTests+Cancellation.swift 0.00% 5 Missing ⚠️
Sources/NetworkServiceTestHelper/Delay.swift 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   76.15%   74.85%   -1.30%     
==========================================
  Files          28       24       -4     
  Lines         717      684      -33     
==========================================
- Hits          546      512      -34     
- Misses        171      172       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-jarvis r-jarvis merged commit 9a0c6a0 into main Apr 19, 2024
2 of 4 checks passed
@roanutil roanutil deleted the swift-http-types branch April 19, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants