Skip to content

Commit

Permalink
Merge pull request #5 from MFB-Technologies-Inc/feature/stop-schemes-…
Browse files Browse the repository at this point in the history
…from-polluting-dependents

- Add .swiftpm to gitignore to stop schemes from polluting packages that depend on NetworkService
- Run swiftformat
- Update ci.yml to use newer codecov flow
- Add codecov badge to README
- Remove unnecessary use of `try!`. Resolves issue #1.
- Add missing assertion descriptions in tests. Resolves swiftlint warnings.
  • Loading branch information
roanutil authored Nov 15, 2022
2 parents 036aaf9 + cff6b0e commit c8ffdc2
Show file tree
Hide file tree
Showing 24 changed files with 58 additions and 563 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@ jobs:
- name: Lint
run: swiftlint .
- name: Run Tests
run: swift test --enable-code-coverage
run: swift test --enable-code-coverage --parallel
- name: Swift Coverage Report
uses: maxep/[email protected]
- name: Code Coverage
run: bash <(curl -s https://codecov.io/bash) -X xcodellvm
run: xcrun llvm-cov export -format="lcov" .build/debug/NetworkServicePackageTests.xctest/Contents/MacOS//NetworkServicePackageTests -instr-profile .build/debug/codecov/default.profdata > coverage_report.lcov
- uses: codecov/codecov-action@v3
with:
fail_ci_if_error: true # optional (default = false)
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ playground.xcworkspace
# *.xcodeproj
# Xcode automatically generates this directory with a .xcworkspacedata file and xcuserdata
# hence it is not needed unless you have added a package configuration file to your project
# .swiftpm
/.swiftpm

.build/
/.build

# CocoaPods
# We recommend against adding the Pods directory to your .gitignore. However
Expand Down
7 changes: 0 additions & 7 deletions .swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata

This file was deleted.

205 changes: 0 additions & 205 deletions .swiftpm/xcode/xcshareddata/xcschemes/NetworkService-Package.xcscheme

This file was deleted.

77 changes: 0 additions & 77 deletions .swiftpm/xcode/xcshareddata/xcschemes/NetworkService.xcscheme

This file was deleted.

This file was deleted.

Loading

0 comments on commit c8ffdc2

Please sign in to comment.