Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add events to history manager #20

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jcdrouin21
Copy link

Summary of Changes

This PR aims to add the majority of events that we might want to log in the history. It allows each wallet to have control over the events it wants to add in the history.
Exemple of some entries:
image

Screenshots, videos, or gifs

Replace this text with embedded media for UI changes if they are included in this PR. If there are none, simply enter N/A

Breaking change guide

Replace this text with any breaking changes included in this PR along with how to address them in downstream projects. If there are none, simply enter N/A

Related Issues

Replace this text with issue #'s that are relevant to this PR. If there are none, simply enter N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • Updated documentation as needed for changed code and new or modified features
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

Copy link

@fc-santos fc-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voir mes commentaires

Signed-off-by: Jean-Christophe Drouin <[email protected]>
Signed-off-by: Jean-Christophe Drouin <[email protected]>
Comment on lines +374 to +383
"CardRemoved": "Card removed",
"CardRevoked": "Card revoked",
"InformationSent": "Information sent to:",
"CardUpdates": "Card updates",
"WalletPinUpdated": "Wallet PIN updated",
"InformationSent": "Information sent to:",
"InformationNotSent": "Information not sent to:",
"Connection": "Connection",
"ConnectionRemoved": "Connection removed",
"ActivateBiometry": "Biometrics activated",
"DeactivateBiometry": "Biometrics deactivated"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On ne devrait pas ajouter ici à la fin de chaque texte (PT-BR) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants