Feat/inject header right #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Claude Arseneault <[email protected]>
Signed-off-by: Claude Arseneault <[email protected]>
fc-santos
reviewed
Nov 15, 2024
fc-santos
reviewed
Nov 15, 2024
fc-santos
reviewed
Nov 15, 2024
fc-santos
reviewed
Nov 15, 2024
| const defaultStackOptions = useDefaultStackOptions(theme) | ||
| const [Options] = useServices([TOKENS.COMPONENT_OPTIONS]) |
fc-santos
reviewed
Nov 15, 2024
fc-santos
reviewed
Nov 15, 2024
|
|
||
| const HomeStack: React.FC = () => { | ||
| const Stack = createStackNavigator<HomeStackParams>() | ||
| const theme = useTheme() | ||
| const { t } = useTranslation() | ||
| const [store] = useStore() | ||
| const defaultStackOptions = useDefaultStackOptions(theme) | ||
| const [Options] = useServices([TOKENS.COMPONENT_OPTIONS]) |
fc-santos
reviewed
Nov 15, 2024
fc-santos
reviewed
Nov 15, 2024
fc-santos
reviewed
Nov 15, 2024
fc-santos
reviewed
Nov 15, 2024
fc-santos
reviewed
Nov 15, 2024
| proofDetailsStackOptions: { headerRight: HeaderRightHome }, | ||
| proofReqUsageHistoryStackOptions: { headerRight: HeaderRightHome }, | ||
| credentialsStackOptions: { headerLeft: SettingsMenu }, | ||
| globalConnectionStackOptions: { headerRight: HeaderRightHome, headerLeft: () => null }, |
There was a problem hiding this comment.
Pourquoi mettre le headerLeft à () => null ? Peut-être juste le retirer serait correct.
There was a problem hiding this comment.
Il était comme ça au départ dans la stack, je me suis dit qu'il y avait probablement une raison
Signed-off-by: Claude Arseneault <[email protected]>
Signed-off-by: Claude Arseneault <[email protected]>
Signed-off-by: Claude Arseneault <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: Claude Arseneault <[email protected]>
Signed-off-by: Claude Arseneault <[email protected]>
Signed-off-by: ClaudeArs <[email protected]>
Signed-off-by: ClaudeArs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Replace this text with a high-level summary of the changes included in this PR.
Related Issues
Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.