Fix #37. Fatal error in storage input checks with multiple storage un…

…its. Thanks to Keir Steegstra.
MATPOWER · Oct 4, 2023 · 4935176 · 4935176
1 parent d1411fa
commit 4935176
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -5,6 +5,11 @@ Change history for MOST
 since 1.2
 ---------
 
+#### 10/4/23
+ - Fix [issue #37][9] which caused a fatal error in storage input checks
+ with multiple storage units under some circumstances.
+ *Thanks to Keir Steegstra.*
+
 #### 2/3/23
  - Remove extra column in ExpectedRampCost and ignore for single period.
 
@@ -304,3 +309,4 @@ Version 1.0 - *Jun 1, 2016*
 [6]: https://doi.org/10.1109/TPWRS.2020.3045162
 [7]: https://arxiv.org/abs/2204.08140
 [8]: https://github.com/MATPOWER/most/issues/29
+[9]: https://github.com/MATPOWER/most/issues/37
diff --git a/docs/src/MOST-manual/MOST-manual.tex b/docs/src/MOST-manual/MOST-manual.tex
@@ -3427,6 +3427,29 @@ \subsubsection*{Incompatible Changes}
 Previously it should have been $\gamma^{t+1}$, as it was in the code.
 \end{itemize}
 
+
+\subsection{Version 1.2.x -- released xxx xx, 202x}
+\label{app:v12x}
+
+The \href{https://matpower.org/docs/MOST-manual-1.2.x.pdf}{\most{} 1.2.x User's Manual} is available online.\footnote{\url{https://matpower.org/docs/MOST-manual-1.2.pdf}}
+
+\subsubsection*{Changes}
+\begin{itemize}
+\item 
+
+\end{itemize}
+
+\subsubsection*{Bugs Fixed}
+\begin{itemize}
+\item Fix issue \#37 which caused a fatal error in storage input checks with multiple storage units under some circumstances. \emph{Thanks to Keir Steegstra.}
+\end{itemize}
+
+\subsubsection*{Incompatible Changes}
+\begin{itemize}
+\item Remove extra column in \code{mdo.results.ExpectedRampCost} and ignore for single period.
+\end{itemize}
+
+
 % \subsection{Version 1.2 -- released ??? ?, 2022}
 % \label{app:v12}
 % 

diff --git a/lib/most.m b/lib/most.m
@@ -275,7 +275,7 @@
  mdi.Storage.InitialStorageLowerBound = mdi.Storage.InitialStorage;
  end
  elseif max(mdi.idx.nj) == 1 && ~mo.ForceCyclicStorage && ...
- mdi.Storage.InitialStorageLowerBound ~= mdi.Storage.InitialStorage
+ any(mdi.Storage.InitialStorageLowerBound ~= mdi.Storage.InitialStorage)
  warning('Deterministic problem with ForceCyclicStorage = 0, setting InitialStorageLowerBound = InitialStorage')
  mdi.Storage.InitialStorageLowerBound = mdi.Storage.InitialStorage;
  end
@@ -286,7 +286,7 @@
  mdi.Storage.InitialStorageUpperBound = mdi.Storage.InitialStorage;
  end
  elseif max(mdi.idx.nj) == 1 && ~mo.ForceCyclicStorage && ...
- mdi.Storage.InitialStorageUpperBound ~= mdi.Storage.InitialStorage
+ any(mdi.Storage.InitialStorageUpperBound ~= mdi.Storage.InitialStorage)
  warning('Deterministic problem with ForceCyclicStorage = 0, setting InitialStorageUpperBound = InitialStorage')
  mdi.Storage.InitialStorageUpperBound = mdi.Storage.InitialStorage;
  end